Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencySatisfies only reliable with a peerDep #58

Merged
merged 2 commits into from
Jan 13, 2022
Merged

dependencySatisfies only reliable with a peerDep #58

merged 2 commits into from
Jan 13, 2022

Commits on Jan 13, 2022

  1. dependencySatisfies only reliable with a peerDep 

    This addon uses `dependencySatisfies` to check the ember-source version. But unless you have a peerDep on ember-source, that was unreliable depending on Yarn/NPM optimization behaviors. And now as of embroider-build/embroider#1070 we're making `dependencySatisfies` strict so that it won't accidentally work sometimes when you don't actually declare a dependency or peerDependency.
    @ef4
    ef4 authored Jan 13, 2022
    Configuration menu
    Copy the full SHA
    b41602e View commit details
    Browse the repository at this point in the history

  2. update @embroider/test-setup for bugfixes

    @ef4
    ef4 committed Jan 13, 2022
    Configuration menu
    Copy the full SHA
    9f5ca9c View commit details
    Browse the repository at this point in the history