Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#each with else block causes problem #11140

Closed
ilkkao opened this issue May 12, 2015 · 5 comments
Closed

#each with else block causes problem #11140

ilkkao opened this issue May 12, 2015 · 5 comments
Labels
Bug
Milestone
1.13.x

Comments

@ilkkao
Copy link
Contributor

ilkkao commented May 12, 2015

Jsbin: http://jsbin.com/dirukazagi/3/edit?html,js,output

Browser error Uncaught TypeError: Cannot read property 'insertBefore' of null

It looks like the each helper mutates 'model` property and sets it to null.
@ilkkao
Copy link
Contributor Author

ilkkao commented May 12, 2015

In the jsbin I mean that if you remove else block, the problem disappears.

@rwjblue
Copy link
Member

rwjblue commented May 12, 2015

Thanks for the report! The JSBin should help us isolate the cause...

@rwjblue rwjblue added the Bug label May 12, 2015
@rwjblue rwjblue added this to the 1.13.0-beta.1 milestone May 12, 2015
@rwjblue
Copy link
Member

rwjblue commented May 14, 2015

Created a failing test case for this at: https://github.com/emberjs/ember.js/compare/each-inverse-to-template.

This was referenced May 18, 2015
Closed
Merged
@hibariya
Copy link
Contributor

I'm also facing this issue. Any updates?

@rwjblue rwjblue mentioned this issue Jun 3, 2015
Merged
@SebastianEdwards
Copy link

I'm also facing this issue. Any updates?

tomdale pushed a commit that referenced this issue Jun 11, 2015
@tilde-engineering @tomdale
Bump htmlbars, fixes #11140
dafa0ad
rwjblue pushed a commit that referenced this issue Jun 13, 2015
@tilde-engineering @rwjblue
Bump htmlbars, fixes #11140
8ff61fc 
(cherry picked from commit dafa0ad)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
1.13.x
Development

No branches or pull requests
4 participants
@rwjblue @hibariya @ilkkao @SebastianEdwards