Skip to content
This repository has been archived by the owner on Mar 15, 2020. It is now read-only.

Upgrade ember, ember-cli and ember-data #51

Merged
merged 8 commits into from
Jun 11, 2015
Merged

Conversation

jpadilla
Copy link
Collaborator

No description provided.

@gcollazo
Copy link
Owner

When you do a search that returns no results and the {{else}} inside the {{each}} is invoked everything works fine. But if you reset the search and ember tries to re-render the list we get an exception and the list rendering stops.

Uncaught TypeError: Cannot read property 'insertBefore' of null

Steps to reproduce:

  • Search for something that returns no results like, "zzzzz".
  • Reset the search so that ember tries to re-render the list.
  • Check your console.

Also tried to move to the syntax, but we need the tagName to be a <tr> and that doesn't work either. The tagName property on the component.js has no effect on the DOM that is produced.

I think we are suffering from issue emberjs/ember.js#11164.

@rwjblue
Copy link
Contributor

rwjblue commented May 20, 2015

It is almost definitely emberjs/ember.js#11140, not emberjs/ember.js#11164 (unless you are using itemViewClass / itemController or another hash parameter for {{each}} that causes us to fallback to LegacyEachView).

@gcollazo
Copy link
Owner

Yes you are right, we are not using itemViewClass / itemController.

@jpadilla jpadilla changed the title Upgrade to ember 1.13.0-beta.1 and ember-data 1.0.0-beta.17 Upgrade ember, ember-cli and ember-data Jun 11, 2015
@jpadilla
Copy link
Collaborator Author

emberjs/ember.js#11140 is now fixed in canary and fixed our original issue here.

Went ahead and updated ember to canary, updated ember-cli to 0.2.7, and ember-data to 1.0.0-beta.18.

I ran into issues with ember-data >= 1.0.0-beta.19 and computedFilterByQuery where the results returned in filteredPackages was an array of InternalModel instead of DS.Model.

@jpadilla jpadilla deployed to ember-cli-addon-search-pr-51 June 11, 2015 15:39 Active
gcollazo pushed a commit that referenced this pull request Jun 11, 2015
Upgrade ember, ember-cli and ember-data
@gcollazo gcollazo merged commit 44d4a1d into gcollazo:master Jun 11, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants