Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for .@each and .[] are unclear about use-cases #12360

Closed
jamesarosen opened this issue Sep 17, 2015 · 4 comments
Closed

Docs for .@each and .[] are unclear about use-cases #12360

jamesarosen opened this issue Sep 17, 2015 · 4 comments
Labels
Documentation Good for New Contributors Help Wanted

Comments

@jamesarosen
Copy link

The docs for .@each and .[] properties aren't clear that .@each should never be used as a terminal and .[] should only be used as a terminal.

See #11994 (comment)
@stefanpenner
Copy link
Member

👍

jamesarosen pushed a commit to fastly/ember-nf-graph that referenced this issue Sep 17, 2015
Use .@each for non-terminal dependency keys
a1a09cb 
The Ember docs aren't completely clear, but the correct usage for
array dependencies is

 * `foo.[]` (use `.[]` when it's at the end)
 * `[email protected]` (use `.@each` when it's in the middle)

Partially reverts 5dac002
See emberjs/ember.js#12360
@jamesarosen jamesarosen mentioned this issue Sep 17, 2015
Merged
jamesarosen pushed a commit to jamesarosen/ember-nf-graph that referenced this issue Sep 17, 2015
Change terminal .@each to .[] in dependency keys
cd52e90 
The Ember docs aren't completely clear, but the correct usage for array dependencies is

 * `foo.[]` (use `.[]` when it's at the end)
 * `[email protected]` (use `.@each` when it's in the middle)

See emberjs/ember.js#12360
@jamesarosen jamesarosen mentioned this issue Sep 17, 2015
Open
@kellyselden
Copy link
Member

I have this bookmarked for whenever I need a reminder.

#2016 (comment)

@pixelhandler
Copy link
Contributor

@jamesarosen true that will be helpful to clarify :)

abepetrillo added a commit to abepetrillo/ember.js that referenced this issue Mar 28, 2016
@abepetrillo
[DOC] Add more guidance on using @each rather than []
f2b42ab 
Updated docs in response to
emberjs#12360
@abepetrillo abepetrillo mentioned this issue Mar 28, 2016
Merged
rwjblue pushed a commit that referenced this issue Apr 3, 2016
@abepetrillo @rwjblue
[DOC] Add more guidance on using @each rather than []
78eaf04 
Updated docs in response to
#12360

(cherry picked from commit f2b42ab)
rwjblue pushed a commit that referenced this issue Apr 3, 2016
@abepetrillo @rwjblue
[DOC] Add more guidance on using @each rather than []
e0e8f7f 
Updated docs in response to
#12360

(cherry picked from commit f2b42ab)
@rwjblue
Copy link
Member

rwjblue commented Apr 14, 2016

Closed by e0e8f7f, and a fix by @krisselden (which I can't find the link for ATM) that makes terminal @each expand to .[].

@rwjblue rwjblue closed this as completed Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Documentation Good for New Contributors Help Wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@stefanpenner @jamesarosen @mixonic @rwjblue @pixelhandler @kellyselden