Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add more guidance on using @each rather than [] #13198

Merged
merged 2 commits into from
Mar 30, 2016

Conversation

abepetrillo
Copy link
Contributor

Updated docs in response to #12360

@each should not be used as a leaf node.

@@ -540,8 +540,23 @@ export default Mixin.create(Enumerable, {
return an enumerable that maps automatically to the named key on the
member objects.

If you merely want to watch for any items being added or removed to the array,
use the `[]` property instead of `@each`.
@each should only be used in a non-terminal context, and is deprecated when
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't deprecated any more 😿, can you remove mention of the deprecation? (all of other changes look great!)

@abepetrillo
Copy link
Contributor Author

@rwjblue updated

@rwjblue rwjblue merged commit 3084885 into emberjs:master Mar 30, 2016
@rwjblue
Copy link
Member

rwjblue commented Mar 30, 2016

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants