-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
{{link-to}}
transitioning classes are incorrect after transition.abort()
#13164
Comments
{{link-to}}
classes are incorrect after calling transition.abort()
{{link-to}}
transitioning classes are incorrect after transition.abort()
possibly related: #10195 |
Failing test: #13165 |
Good point. Reopened. |
@GavinJoyce I updated the twiddle example using v2.5.1 https://ember-twiddle.com/5e91f27f1df42b6e41231f53a12af3da?openFiles=application.template.hbs%2C&route=%2Fpage1 and labeled "BUG" |
Just got bit by this issue, found via #15518. Is there a workaround to force ember to recompute link-to active states? The workaround mentioned in that ticket does not seem to work for me. |
So, this was somewhat of a rabbithole. I was able to reproduce the specific issue I was having on a twiddle here: https://ember-twiddle.com/128d462ce1fa0acdebd696338ca3dc14?openFiles=templates.application.hbs%2C In particular, my issue was due to a I found a workaround here: #10557 which thankfully works (essentially replaces In my digging, I found a number of related tickets, linking them all here - these all seem related to me: There are a number of twiddles / jsbins across those issues that reproduce different variations of the issue. They all seem related to a Hopefully this helps identify the issue. We were experiencing it in our production app on the latest ember (2.14.x), but it has been an issue for us for quite some time. I was previously working around it by using jquery to fix the classes, I only just now spent the time to investigate why it was occurring. |
Also experiencing this issue all of a sudden. Probably since upgrading some dependencies. I'll try to reproduce it. |
Closed by #13169 |
Oops, someone posted it on the triage channel. Reopening! |
this issue still happening for me, I am using ember-cli version 2.18.2 |
@anpenava the ember-cli version should be irrelevant here. What is your Ember.js (ember-source) version? :) |
@buschtoens |
This appears to still be an issue I updated the ember-twiddle example, https://ember-twiddle.com/5e91f27f1df42b6e41231f53a12af3da?openFiles=application.controller.js%2C |
A possibly related issue, I've noticed that if some of the details on a link change, like say the query parameters, while the link is being transitioned into it causes the same issue. |
twiddle: https://ember-twiddle.com/8aa9da800a7883b6c59a?openFiles=routes.page2.js%2C
The
ember-transitioning-in
and.ember-transitioning-out
classes don't seem to be updated correctly when linking to a route that aborts the transition:I'll try to create a failing test now
The text was updated successfully, but these errors were encountered: