[BUGFIX beta] Fixes {{link-to}} classes when transition is aborted #13169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinJoyce
changed the title
|
This seems good to me. @machty - Would love your eyes on this to make sure I'm not missing something... |
|
👍 thanks for digging into this :) |
|
@machty - Thanks for reviewing! |
|
@GavinJoyce There is a new issue. Active class is missing when redirecting in before/afterModel. Will investigate and provide an example. |
|
@medokin thanks, I'll look into this now |
rwjblue
added a commit
that referenced
this pull request
Apr 5, 2016
[BUGFIX beta] revert #13169 and add test to cover {{link-to}} active class regression
rwjblue
pushed a commit
that referenced
this pull request
Apr 11, 2016
…class regression (cherry picked from commit 026f1bf)
toddjordan
pushed a commit
to toddjordan/ember.js
that referenced
this pull request
Sep 9, 2016
…active class regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #13164