Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engines + visit test issue #14086

Closed
asakusuma opened this issue Aug 18, 2016 · 3 comments
Closed

Engines + visit test issue #14086

asakusuma opened this issue Aug 18, 2016 · 3 comments
Labels

Comments

@asakusuma
Copy link
Contributor

I noticed that #14055 if failing only on the prod and jquery suite. I dug further and it would appear that engines + visit + shouldRender: true causes some issues with the run loop in the tests, but only in prod and jquery extended prototype suites.

Should not be in a run loop at end of test
Ember run should not have scheduled timers at end of test
Assertion Failed: You have turned on testing mode, which disabled the run-loop's autorun. You will need to wrap any code with asynchronous side-effects in a run

Here is a failing PR to repro: #14085

cc @dgeb @krisselden @trentmwillis

@rwjblue
Copy link
Member

rwjblue commented Aug 18, 2016

@asakusuma - FWIW, the eachPackageTests were completely broken and running no tests until #14084.

@asakusuma
Copy link
Contributor Author

Thanks @rwjblue. This issue was happening both before and after that PR.

I've confirmed locally that this issue happens when enableoptionalfeatures is both on and off, which would suggest that the issue is independent of glimmer.

@rwjblue
Copy link
Member

rwjblue commented Aug 31, 2016

I believe this is fixed (I closed the related failing test PR #14085).

@rwjblue rwjblue closed this as completed Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants