Repro engines + visit test issue #14085
Conversation
| assert.ok(instance instanceof ApplicationInstance, 'promise is resolved with an ApplicationInstance'); | ||
| assert.strictEqual(jQuery('#qunit-fixture').children().length, 0, 'there are still no elements in the fixture element after visit'); | ||
| assert.strictEqual(0, 0, 'there are still no elements in the fixture element after visit'); |
There was a problem hiding this comment.
@chancancode I'm just reproducing a problem, not actually expecting this to get merged. This set of changes should not fail the test suite, but it does.
|
I chatted with @krisselden and @dgeb earlier today about this, and we think we may have come up with an explanation here. Basically, the renderer is not being shared between the host and the engine. This ends up causing both app renderer and engine renderer to setup the normal run looping things, and causes it to end up being out of sync. Right now this is the list of instances shared between the host and the engine. We think that the renderer and environment need to be added to that list. |
asakusuma
force-pushed
the
engines-test-issue-repro
branch
from
854584b
to
33744d5
Compare
|
☔ The latest upstream changes (presumably #14135) made this pull request unmergeable. Please resolve the merge conflicts. |
|
I believe this issue is resolved. Closing for now, but I can reopen if you see it crop up again. |
Fixes emberjs#14029 Related to emberjs#14085
Fixes emberjs#14029 Related to emberjs#14085
Fixes emberjs#14029 Related to emberjs#14085
Repro #14086