Fix basic component and helper resolution in engines #14055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2,6 +2,14 @@ import { Template } from 'glimmer-runtime'; | |||
|
|
|||
| class Wrapper { | |||
| constructor(id, env, spec) { | |||
There was a problem hiding this comment.
The factory should be passed the owner, we should use the owner of the template, the env really should come from the app and be passed into the engine with instantiate false. /cc @dgeb
|
@dgeb please review |
asakusuma
force-pushed
the
glimmer-owner
branch
3 times, most recently
from
9ee3e5f
to
aa5e739
Compare
|
☔ The latest upstream changes (presumably #14102) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@asakusuma sorry to delay following up. @rwjblue and I talked with @krisselden and have some ideas about how to resolve this, which we'll try to do in the next few days. |
asakusuma
force-pushed
the
glimmer-owner
branch
from
aa5e739
to
4988d0e
Compare
|
☔ The latest upstream changes (presumably #14119) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensured that tests fail before fix
cc @krisselden @chancancode