Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-source@3 + ember-cli@3 does not generate valid tests #16344

Closed
nathanhammond opened this issue Mar 8, 2018 · 2 comments
Closed

ember-source@3 + ember-cli@3 does not generate valid tests #16344

nathanhammond opened this issue Mar 8, 2018 · 2 comments

Comments

@nathanhammond
Copy link
Member

nathanhammond commented Mar 8, 2018

As of ember-cli/ember-cli#7546 landing, we no longer have any helpers in Ember CLI.

This breaks the blueprints for instance-initializers and initializers.

It also is broken for Mocha acceptance tests:
https://github.com/emberjs/ember.js/blob/master/blueprints/acceptance-test/mocha-files/tests/acceptance/__name__-test.js

(I'm not sure that I've enumerated everywhere that it fails.)

This bug is effectively a duplicate of #16180, but exists because #16229 is incomplete.

@nathanhammond nathanhammond changed the title ember-source@master + ember-cli@3 does not generate valid tests ember-source@3 + ember-cli@3 does not generate valid tests Mar 8, 2018
@rwjblue
Copy link
Member

rwjblue commented Mar 8, 2018

@nathanhammond - RE: the Mocha point: ember-mocha re-regenerates the start-app and destroy-app helpers (because it isn't quite finished with support for the newer testing system).

@Serabe
Copy link
Member

Serabe commented Mar 9, 2018

Thank you!

kategengler pushed a commit that referenced this issue Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants