[BUGFIX] Don't use destroyApp if new API is being used #16229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems good, but I think you also need to fixup the fixture that we test against (the blueprint tests are failing)... |
|
Will fix on Monday.
|
|
Ping as a friendly reminder @Serabe! |
|
instance-initializer-test blueprint also needs to be updated. |
|
Had a tough week. Try to do it tomorrow, as today I am attending a conference. |
|
Found the problem. I forgot to commit two files (－‸ლ) |
nag5000
reviewed
Feb 19, 2018
| @@ -13,7 +13,7 @@ module('<%= friendlyTestName %>', { | |||
| }); | |||
| }, | |||
| afterEach() { | |||
| destroyApp(this.application); | |||
| <% if (destroyAppExists) { %>destroyApp(this.application);<% } else { %>run(application, 'destroy');<% } %> | |||
|
@rwjblue I believe this is a bugfix for 3.0 stable? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16180