Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native classes in app/router.js #18166

Closed
3 of 4 tasks
tomdale opened this issue Jul 1, 2019 · 5 comments · Fixed by ember-cli/ember-octane-blueprint#149
Closed
3 of 4 tasks

Support native classes in app/router.js #18166

tomdale opened this issue Jul 1, 2019 · 5 comments · Fixed by ember-cli/ember-octane-blueprint#149

Comments

@tomdale
Copy link
Member

tomdale commented Jul 1, 2019

Currently, ember g route foo will fail with an error if app/router.js uses newer JavaScript syntax like class fields or decorators. We should update this generator to ensure that this works correctly if people migrate this file to use native JavaScript syntax.

The bulk of the functionality of this generator lives in https://github.com/ember-cli/ember-router-generator, so this is largely a tracking issue for changes in that repo.

  • Support parsing class fields and decorators (PR)
  • Release [email protected]
  • Update ember-router-generator version included with ember-source
  • Update Octane blueprint to generate app/router.js file with native class syntax
@rwjblue
Copy link
Member

rwjblue commented Jul 3, 2019

Just released [email protected], should get a dependabot PR soon...

@gabrielgrant
Copy link

not seeing a dependabot PR for this...is that because it's configured to limit the number of PRs it will have open on a repo and it's already at it's max (which appears to be 10?). Or is there something actually blocking this?

Copy link
Member

rwjblue commented Aug 11, 2019

Nothing blocking to my knowledge, definitely welcome a PR.

@xg-wang
Copy link
Contributor

xg-wang commented Aug 17, 2019

This seems easy, should I do the following:

  1. land Bump ember-router-generator from v1.2.3 to v2.0.0 #18278
  2. wait a canary release
  3. update ember-cli/ember-octane-blueprint

@rwjblue
Copy link
Member

rwjblue commented Aug 20, 2019

@xg-wang thank you! I submitted ember-cli/ember-octane-blueprint#149 to close this out...

rwjblue added a commit to rwjblue/ember-octane-blueprint that referenced this issue Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants