-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support native classes in app/router.js #18166
Comments
Just released [email protected], should get a dependabot PR soon... |
not seeing a dependabot PR for this...is that because it's configured to limit the number of PRs it will have open on a repo and it's already at it's max (which appears to be 10?). Or is there something actually blocking this? |
Nothing blocking to my knowledge, definitely welcome a PR. |
This seems easy, should I do the following:
|
@xg-wang thank you! I submitted ember-cli/ember-octane-blueprint#149 to close this out... |
Currently,
ember g route foo
will fail with an error ifapp/router.js
uses newer JavaScript syntax like class fields or decorators. We should update this generator to ensure that this works correctly if people migrate this file to use native JavaScript syntax.The bulk of the functionality of this generator lives in https://github.com/ember-cli/ember-router-generator, so this is largely a tracking issue for changes in that repo.
app/router.js
file with native class syntaxThe text was updated successfully, but these errors were encountered: