[BUGFIX beta] Remove access to this in HTMLBars helpers.
#10554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The value of `this` in a helper has changed at least twice (likely more). This updates the HTMLBars hooks to call each helper with an `undefined` context. The main purpose of this is to pave the way for another refactoring of the view + helper layer that uses `this` for a different purpose. To fix any usages of `this` in a helper, you can access the `view` from `env.data.view` instead.
rwjblue
added a commit
that referenced
this pull request
Mar 1, 2015
[BUGFIX beta] Remove access to `this` in HTMLBars helpers.
rlivsey
added a commit
to rlivsey/ember-intl
that referenced
this pull request
Mar 1, 2015
Uses `env.data.view` to get the container, which has been available since 1.10.0-beta.1, so this is safe for all HTMLBars Ember versions. See emberjs/ember.js#10554 for context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
thisin a helper has changed at least twice (likely more). This updates the HTMLBars hooks to call each helper with anundefinedcontext. The main purpose of this is to pave the way for another refactoring of the view + helper layer that usesthisfor a different purpose.To fix any usages of
thisin a helper, you can access theviewfromenv.data.viewinstead.