Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Remove access to this in HTMLBars helpers. #10554

Merged
merged 1 commit into from
Mar 1, 2015
Merged

[BUGFIX beta] Remove access to this in HTMLBars helpers. #10554

merged 1 commit into from
Mar 1, 2015

Commits on Mar 1, 2015

  1. [BUGFIX beta] Remove access to this in HTMLBars helpers. 

    The value of `this` in a helper has changed at least twice (likely
more). This updates the HTMLBars hooks to call each helper with an
`undefined` context. The main purpose of this is to pave the way for
another refactoring of the view + helper layer that uses `this` for a
different purpose.

To fix any usages of `this` in a helper, you can access the `view` from
`env.data.view` instead.
    @rwjblue
    rwjblue committed Mar 1, 2015
    Configuration menu
    Copy the full SHA
    5d6353a View commit details
    Browse the repository at this point in the history