[BUGFIX release] Ensure injected property assertion checks container.
#13335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the Ember 2.3.0 cycle, we introduced the `getOwner` / `setOwner` concepts and deprecated using the injected `.container` property on objects. Unfortunately, if you are using an older library to create objects that hasn't been updated to use `setOwner` you would only have the `container` specified which causes this injection assertion to be thrown (since `getOwner(this)` returns undefined). Specifically, using Ember Data 1.13.<latest> with Ember 2.4.5 and having a model with an injected property will trigger an assertion.
|
Nice little fix @rwjblue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the Ember 2.3.0 cycle, we introduced the
getOwner/setOwnerconcepts and deprecated using the injected.containerproperty on objects. Unfortunately, if you are using an older library to create objects that hasn't been updated to usesetOwneryou would only have thecontainerspecified which causes this injection assertion to be thrown (sincegetOwner(this)returns undefined).Specifically, using Ember Data 1.13. with Ember 2.4.5 and having a model with an injected property will trigger an assertion.