Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX release] Ensure injected property assertion checks container. #13335

Merged
merged 1 commit into from
Apr 14, 2016
Merged

[BUGFIX release] Ensure injected property assertion checks container. #13335

merged 1 commit into from
Apr 14, 2016

Commits on Apr 14, 2016

  1. [BUGFIX release] Ensure injected property assertion checks container. 

    During the Ember 2.3.0 cycle, we introduced the `getOwner` / `setOwner`
concepts and deprecated using the injected `.container` property on
objects. Unfortunately, if you are using an older library to create
objects that hasn't been updated to use `setOwner` you would only have
the `container` specified which causes this injection assertion to be
thrown (since `getOwner(this)` returns undefined).

Specifically, using Ember Data 1.13.<latest> with Ember 2.4.5 and having
a model with an injected property will trigger an assertion.
    @rwjblue
    rwjblue committed Apr 14, 2016
    Configuration menu
    Copy the full SHA
    8c15226 View commit details
    Browse the repository at this point in the history