Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update route-recognizer. #13966

Closed

Conversation

nathanhammond
Copy link
Member

@nathanhammond nathanhammond commented Jul 30, 2016

Do not merge.

This is the complete enumeration of tasks gating landing of what will be the next version of route-recognizer into Ember. I'm hoping to land this as part of 2.9.

  • Port build into ember-route-recognizer.
  • Port benchmarks into ember-route-recognizer.
  • Add warning for duplicate route addition.
  • ES3-ify dist/*.
  • Performance
    • Ensure benchmarks are approximately the same speed or better.
    • Convert to TypeScript
    • Do a better job at serialization (breadth-first compaction).
  • Improve the automatic serialization build process.
    • Make it less brittle.
    • Make the addon version's build process strip out the compiled-in route-recognizer when used with older versions of Ember.
  • Testing
    • End-to-end Ember tests.
    • More obnoxious permutations.
    • Add node-tests for the build process.
  • Implement RFC #154
    • Optional Segments
    • Dynamic Segment Constraints
  • Add support for this.delegate. Originally added here.
  • Optimize out unreachable routes alerts user.
  • Repository shuffling?

@homu
Copy link
Contributor

homu commented Aug 12, 2016

☔ The latest upstream changes (presumably #14058) made this pull request unmergeable. Please resolve the merge conflicts.

@rwjblue
Copy link
Member

rwjblue commented Nov 10, 2016

@nathanhammond - This is still on your radar (just delayed), right?

@nathanhammond
Copy link
Member Author

nathanhammond commented Nov 10, 2016

Not only on my radar, still making progress: https://github.com/nathanhammond/ember-route-recognizer/commits/master

On 11/5 I built a 100% working copy of Ember with my route-recognizer fork. Need to write high quality benchmarks that can be run in different modes (clean visit, Fastboot with pre-built-route table, etc.) before proceeding with the perf work.

@marcemira
Copy link

👋 @nathanhammond - Just wanted to know if this still going to happen. Thanks 🙏

@mmun
Copy link
Member

mmun commented Feb 23, 2018

Closing as stale. (Route recognizer is already at version 0.3.3).

@mmun mmun closed this Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants