cleanup active computed property
#15779
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bekzod
changed the title
active computed propertyactive computed property
bekzod
force-pushed
the
link-to-comptued
branch
from
0c4e586
to
29266e0
Compare
locks
approved these changes
Nov 3, 2017
rwjblue
reviewed
Nov 5, 2017
| @@ -592,10 +592,7 @@ const LinkComponent = EmberComponent.extend({ | |||
| @property active | |||
| @private | |||
| */ | |||
| active: computed('attrs.params', '_active', function computeLinkToComponentActiveClass(this: any) { | |||
| let currentState = get(this, '_routing.currentState'); | |||
| if (!currentState) { return false; } | |||
There was a problem hiding this comment.
This existed to avoid computing active if routing was not started (e.g. from integration or unit tests where there is no routing). Can you confirm that _active does not throw in that case?
There was a problem hiding this comment.
it won't I think there is _routing.currentState check in https://github.com/bekzod/ember.js/blob/29266e0977e638f00cb87850ec0856a44fb5bbdf/packages/ember-glimmer/lib/components/link-to.ts#L599 so it is just removing duplication
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.