[BUGFIX] Recompute link-to active prop when attrs.params changes #16060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to 2.18.0, the link-to component would recompute active/_active whenever params changed. This restores prior functionality. I can also add tests when there is buy-in that this wasn't an intentional breaking change.
rwjblue
reviewed
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to 2.18.0, the link-to component would recompute
active/_activewhenattrs.paramschanged. This restores prior functionality where a deeply nested async relationship that resolves after initial render of a link-to and meets the criteriathis._isActivethen the active class is applied to the link element. Currently, that functionality is broken and the active class is never applied when the async relationship settles.I'll update tests before this is merged once it's clear that this wasn't an intentional breaking change.
<= 2.17.0 behavior https://github.com/emberjs/ember.js/blob/v2.17.0/packages/ember-glimmer/lib/components/link-to.js#L593