remove redundant _getModels in link-to
#16958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
approved these changes
Oct 18, 2018
rwjblue
reviewed
Oct 18, 2018
| } else { | ||
| this.set('models', []); | ||
| } | ||
| params.shift(); |
There was a problem hiding this comment.
We should not mutate the params passed in to us
There was a problem hiding this comment.
@rwjblue they are sliced at the very top of the function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
params already cloned here https://github.com/emberjs/ember.js/pull/16958/files#diff-69db29e32cf13d448d7c3db3008d1774L857 so it can be reused