Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove redundant _getModels in link-to #16958

Merged
merged 1 commit into from
Oct 18, 2018
Merged

remove redundant _getModels in link-to #16958

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 2 additions & 18 deletions packages/@ember/-internals/glimmer/lib/components/link-to.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -827,19 +827,6 @@ const LinkComponent = EmberComponent.extend({
return true;
}),

_getModels(params: any[]) {
let modelCount = params.length - 1;
let models = new Array(modelCount);

for (let i = 0; i < modelCount; i++) {
let value = params[i + 1];

models[i] = value;
}

return models;
},

/**
The default href value to use while a link-to is loading.
Only applies when tagName is 'a'
Expand Down Expand Up @@ -891,11 +878,8 @@ const LinkComponent = EmberComponent.extend({
this.set('queryParams', queryParams);

// 4. Any remaining indices (excepting `targetRouteName` at 0) are `models`.
if (params.length > 1) {
this.set('models', this._getModels(params));
} else {
this.set('models', []);
}
params.shift();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should not mutate the params passed in to us

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwjblue they are sliced at the very top of the function

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! thank you @Turbo87

this.set('models', params);
},
});

Expand Down