[BUGFIX beta] Ensures Ember.A is a constructor #17238
Conversation
|
cc @rwjblue |
|
Lets add a private API deprecation ( |
pzuraq
force-pushed
the
bugfix/ensure-array-wrapper-is-a-constructor
branch
from
9181605
to
b6cd574
Compare
|
Updated, and added PR to the deprecation app |
|
FWIW, there is a bit of usage of https://emberobserver.com/code-search?codeQuery=new%20A( |
pzuraq
force-pushed
the
bugfix/ensure-array-wrapper-is-a-constructor
branch
from
b6cd574
to
488195d
Compare
| { | ||
| id: 'array.new-array-wrapper', | ||
| until: '3.9.0', | ||
| url: 'https://emberjs.com/deprecations/v3.x#toc_new-array-wrapper', |
There was a problem hiding this comment.
Seems to be wrong (the url doesn't link directly), when I find the right link it looks like:
https://deprecations-app-prod.herokuapp.com/deprecations/v3.x/#toc_array-new-array-wrapper
Can you confirm which is correct?
There was a problem hiding this comment.
you are correct! Updated
The recent change to transpilation has made `new A()` break, because A is an arrow function and arrow functions cannot be constructors. This is a pretty common pattern in Ember apps and likely constitutes a breaking change, so this PR fixes it by changing the arrow function to a normal function, and deprecates this behavior.
pzuraq
force-pushed
the
bugfix/ensure-array-wrapper-is-a-constructor
branch
from
488195d
to
5a565d5
Compare
|
|
||
| ['@test new Ember.A'](assert) { | ||
| expectDeprecation(() => { | ||
| assert.deepEqual(new A([1, 2]), [1, 2], 'array values were not be modified'); |
There was a problem hiding this comment.
ya, woah this was never an intended feature...
The recent change to transpilation has made
new A()break, becauseA is an arrow function and arrow functions cannot be constructors. This
is a pretty common pattern in Ember apps and likely constitutes a
breaking change, so this PR fixes it by changing the arrow function to
a normal function.