Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Ensures Ember.A is a constructor #17238

Merged
merged 1 commit into from
Nov 30, 2018
Merged

[BUGFIX beta] Ensures Ember.A is a constructor #17238

merged 1 commit into from
Nov 30, 2018

Commits on Nov 29, 2018

  1. [BUGFIX beta] Ensures Ember.A is a constructor 

    The recent change to transpilation has made `new A()` break, because
A is an arrow function and arrow functions cannot be constructors. This
is a pretty common pattern in Ember apps and likely constitutes a
breaking change, so this PR fixes it by changing the arrow function to
a normal function, and deprecates this behavior.
    @pzuraq
    pzuraq committed Nov 29, 2018
    Configuration menu
    Copy the full SHA
    5a565d5 View commit details
    Browse the repository at this point in the history