[BUGFIX] Ensure @sort works on non-Ember.Objects. #17841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This refactors the `sort` reduced computed macro tests in order to easily test both an Ember.Object and a native class.
Assuming that `this.notifyPropertyChange` is a method on the object that the `sort` is operating on is not a safe assumption. Specifically, when operating on a `@glimmer/component` (which is _essentially_ just a very very basic native class) there is no `notifyPropertyChange` method and an error was thrown.
pzuraq
approved these changes
Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming that
this.notifyPropertyChangeis a method on the object that thesortis operating on is not a safe assumption. Specifically, when operating on a@glimmer/component(which is essentially just a very very basic native class) there is nonotifyPropertyChangemethod and an error was thrown.Fixes #17839