Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Ensure @sort works on non-Ember.Objects. #17841

Merged
merged 2 commits into from
Apr 3, 2019
Merged

[BUGFIX] Ensure @sort works on non-Ember.Objects. #17841

merged 2 commits into from
Apr 3, 2019

Commits on Apr 2, 2019

  1. [BUGFIX beta] Failing tests for using @sort on non-Ember.Object. 

    This refactors the `sort` reduced computed macro tests in order to
easily test both an Ember.Object and a native class.
    @rwjblue
    rwjblue committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    ed3b0a3 View commit details
    Browse the repository at this point in the history

  2. [BUGFIX] Ensure @sort works on non-Ember.Objects. 

    Assuming that `this.notifyPropertyChange` is a method on the object that
the `sort` is operating on is not a safe assumption. Specifically, when
operating on a `@glimmer/component` (which is _essentially_ just a very
very basic native class) there is no `notifyPropertyChange` method and
an error was thrown.
    @rwjblue
    rwjblue committed Apr 2, 2019
    Configuration menu
    Copy the full SHA
    00a0c0b View commit details
    Browse the repository at this point in the history