[BUGFIX lts + beta] Ensure modifiers do not run in FastBoot modes. #18071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit ff760cf)
(cherry picked from commit 13e422a)
Prior to this change, custom modifier managers were invoked during non-interactive rendering invocations as well as interactive. In practice, that resulted in custom modifiers erroring whenever they ran in FastBoot / SSR environments. This change, ensures that the interactive / non-interactive state is threaded through to the required infrastructure to avoid invoking _any_ hooks on custom modifier managers when running in non-interactive modes.
Since `{{on}}` is a "special" built-in modifier manager, the generic
fixes for custom modifier managers do not fix `on`. This applies the
same general fix, and ensures that `{{on}}` is a no-op in FastBoot mode.
|
I've tried it out in my production app and it does indeed work as intended! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17949
Note: the fix is split into two different commits to make backporting easier