Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX lts + beta] Ensure modifiers do not run in FastBoot modes. #18071

Merged
merged 4 commits into from
Jun 4, 2019
Merged

[BUGFIX lts + beta] Ensure modifiers do not run in FastBoot modes. #18071

merged 4 commits into from
Jun 4, 2019

Commits on Jun 3, 2019

  1. Add test for non-interactive custom modifier lifecycle hooks 

    (cherry picked from commit ff760cf)
    @CvX @rwjblue
    CvX authored and rwjblue committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    59feb00 View commit details
    Browse the repository at this point in the history

  2. Add test for non-interactive on modifier lifecycle hooks 

    (cherry picked from commit 13e422a)
    @CvX @rwjblue
    CvX authored and rwjblue committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    c514f47 View commit details
    Browse the repository at this point in the history

  3. [BUGFIX lts] Ensure custom modifier managers are not invoked in SSR. 

    Prior to this change, custom modifier managers were invoked during
non-interactive rendering invocations as well as interactive. In
practice, that resulted in custom modifiers erroring whenever they ran
in FastBoot / SSR environments.

This change, ensures that the interactive / non-interactive state is
threaded through to the required infrastructure to avoid invoking _any_
hooks on custom modifier managers when running in non-interactive modes.
    @rwjblue
    rwjblue committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    a3c0b5e View commit details
    Browse the repository at this point in the history

  4. [BUGFIX beta] Ensure {{on}} does not run in FastBoot / SSR contexts. 

    Since `{{on}}` is a "special" built-in modifier manager, the generic
fixes for custom modifier managers do not fix `on`. This applies the
same general fix, and ensures that `{{on}}` is a no-op in FastBoot mode.
    @rwjblue
    rwjblue committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    a82907f View commit details
    Browse the repository at this point in the history