[BUGFIX] Matches assertion behavior for CPs computing after destroy #18222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, there was an assertion that threw whenever a CP was calculated after destroy, _and_ updated its dependent keys (i.e. updated chains). This meant that CPs without any dependencies would still run after destroy, and everything would work. The new assertion always threw if anyone accessed _any_ CP. This changes it to only throw if the CP has dependencies, matching the old behavior.
igorT
reviewed
Jul 30, 2019
igorT
approved these changes
Jul 30, 2019
pzuraq
force-pushed
the
bugfix/tracked/match-previous-cp-assertion-behavior
branch
from
0929dfa
to
7892e34
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, there was an assertion that threw whenever a CP was
calculated after destroy, and updated its dependent keys (i.e.
updated chains). This meant that CPs without any dependencies would
still run after destroy, and everything would work. The new assertion
always threw if anyone accessed any CP. This changes it to only throw
if the CP has dependencies, matching the old behavior.