Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Matches assertion behavior for CPs computing after destroy #18222

Merged
merged 2 commits into from
Jul 30, 2019
Merged

[BUGFIX] Matches assertion behavior for CPs computing after destroy #18222

merged 2 commits into from
Jul 30, 2019

Commits on Jul 30, 2019

  1. [BUGFIX] Matches assertion behavior for CPs computing after destroy 

    Previously, there was an assertion that threw whenever a CP was
calculated after destroy, _and_ updated its dependent keys (i.e.
updated chains). This meant that CPs without any dependencies would
still run after destroy, and everything would work. The new assertion
always threw if anyone accessed _any_ CP. This changes it to only throw
if the CP has dependencies, matching the old behavior.
    Chris Garrett committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    15b7910 View commit details
    Browse the repository at this point in the history

  2. add test

    Chris Garrett committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    7892e34 View commit details
    Browse the repository at this point in the history