[FEATURE modernized-built-in-components] Remaining implementation work #19382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
changed the title
EventDispatcherEventDispatcher
chancancode
force-pushed
the
refactor-input-component
branch
from
04cdf0a
to
5c95b72
Compare
chancancode
changed the title
EventDispatcherEventDispatcher & Modernize <Textarea>
chancancode
force-pushed
the
refactor-input-component
branch
3 times, most recently
from
3d14467
to
31c9392
Compare
chancancode
force-pushed
the
refactor-input-component
branch
4 times, most recently
from
3d74fde
to
c79bf85
Compare
chancancode
force-pushed
the
refactor-input-component
branch
5 times, most recently
from
10c9a89
to
4bb3713
Compare
Instead of hard-coding a list of events to bind (copied from the `EventDispatcher` – which could be reopened and modified), this refactor uses a modifier to dynamically read the list from the `EventDispatcher` at runtime instead. Part of #19270
Switches the <Textarea /> component to use the new implementation as well. Passes all existing tests. Part of #19270
Deprecate all unsupported args (and "deopt" the component for now) according to RFC 707. Part of #19270
…trings Tracking issue: #19270 Get tests passing for no actions passed to inputs as strings deprecation
Refactor to extra shared code into internal component to pave way for implementing <LinkTo> with the new infrastructure. Part of #19270
chancancode
force-pushed
the
refactor-input-component
branch
from
4bb3713
to
6238a51
Compare
chancancode
changed the title
EventDispatcher & Modernize <Textarea>
chancancode
force-pushed
the
refactor-input-component
branch
from
6238a51
to
3d02784
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hard-coding a list of events to bind (copied from the
EventDispatcher– which could be reopened and modified), this refactor uses a modifier to dynamically read the list from theEventDispatcherat runtime instead.Also switches the
<Textarea />component to use the new implementation. Passes all existing tests.Part of #19270