Remove deprecated getWithDefault for v4.0 #19620
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure the `templateOnly` documentation appears in the right place.
[DOC] Link the `templateOnly` docs to the correct package
Ensures that computeds can depend on dynamic hash keys that did not exist on the original hash.
…computeds [BUGFIX lts] Ensures that computed can depend on dynamic hash keys
[BUGFIX release] Extend transitionTo deprecation
No logical changes here, just moving the code to detect and generate the message out into a stand alone module (makes it easier to reason about and possible to unit test). Co-authored-by: Stefan Penner <[email protected]>
Co-authored-by: Stefan Penner <[email protected]>
Fixes a few things: * Ensures that Embroider has a consistent protocol for ensuring the global is bootstrapped * Allows our override code to be transpiled * Ensures that any bootstrapping tweaks force us out of "prebuilt" mode (allowing that customized bootstrap code to actually run) Co-authored-by: Stefan Penner <[email protected]>
This adds the public `CoreObject` methods to the API docs of the `Helper` class.
Also fixed a few minor errors in the message (wrong version number etc) Included a list of hardcoded known dormant addons (polyfills mostly) to make the suggestions more reliable.
(cherry picked from commit e31720c)
[DOC release] Fix "Dormant" addon warning typo
During bubbling, `event.target` may point to a child element whereas `event.currentTarget` always points to the element where the handler was attached, which is what we want here. Reported in a comment on #19546, though this may be a distinct issue from the original report as it was reported as a default-cancelling parent element interfering with the nested `<LinkTo>`, and this is the other way around.
(cherry picked from commit 428e7a0)
The different heading levels are causing issues for services that are trying to read and filter the changelog
Fix Changelog formatting
Fix spelling mistake
(cherry picked from commit 7de1e20)
The previous bugfixes to `{{hash}}` caused a change to the semantics of
computed properties that depend on a hash. Specifically, because
`{{hash}}` objects are now proxies, they are _constant_, never updating
again after they are initially created. This is fine if you depend on
an individual key in a hash, but breaks if you depend directly on the
hash itself:
```js
computed('hash.foo', function() {}) // this works
computed('hash', function() {}) // this will no longer rerun
```
This is used occasionally when you wish to depend on the dynamic keys
of a dictionary, like so:
```js
computed('hash', function() {
let values = [];
for (let key in this.hash) {
values.push(hash[key]);
}
return values;
})
```
Notably, this is not a problem with autotracking, because autotracking
will entangle the usage of these keys dynamically. So this is only a
problem with legacy systems such as `computed` and `observer` which
cannot dynamically add dependencies based on the function's runtime.
To fix this, we need to determine if a dependency is a hash when a
computed or an observer depends upon it, and then entangle all of its
keys if it is. We do this whenever the value is the last value in the
chain.
[BUGFIX lts] Ensure hash objects correctly entangle as dependencies v2
Bumps [glob](https://github.com/isaacs/node-glob) from 7.1.6 to 7.1.7. - [Release notes](https://github.com/isaacs/node-glob/releases) - [Changelog](https://github.com/isaacs/node-glob/blob/master/changelog.md) - [Commits](isaacs/node-glob@v7.1.6...v7.1.7) Signed-off-by: dependabot-preview[bot] <[email protected]>
(cherry picked from commit a01e11d)
|
Lets do this over :-\ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of
19617Deprecation guide.
TEST_SUITE=all yarn testpasses locally