[BUGFIX release] Deprecate htmlSafe via prototype #19690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mixonic
force-pushed
the
mixonic/html-safe-deprecation
branch
from
8738d5d
to
4edd367
Compare
mixonic
force-pushed
the
mixonic/html-safe-deprecation
branch
6 times, most recently
from
d219784
to
56126df
Compare
In Ember 3.24 various string methods added to the `String.prototype` were deprecated for removal in Ember 4.0. `htmlSafe` (the version available via string prototype) was supposed to be included in those deprecations, however dues to its implementation being different it was missed. This omission can be understood as a bug. This patch deprecates `String.prototype.htmlSafe` targeting Ember 4.0. This will allow the removal of *all* string prototype extensions in 4.0 as intended by the original deprecation. See also: emberjs#19654 (comment)
mixonic
force-pushed
the
mixonic/html-safe-deprecation
branch
from
56126df
to
c6c6978
Compare
mixonic
commented
Aug 1, 2021
| id: 'ember-string.prototype-extensions', | ||
| for: 'ember-source', | ||
| since: { | ||
| enabled: '3.27.6', |
There was a problem hiding this comment.
Should be the next 3.27 release.
kategengler
approved these changes
Aug 1, 2021
|
@mixonic should this be added to the deprecation-app? I can do that if so |
|
@nlfurniss yeah I think so, it can join the other string deprecation entry. It doesn't need to be a new entry entirely. |
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Ember 3.24 various string methods added to the
String.prototypewere deprecated for removal in Ember 4.0.htmlSafe(the version available via string prototype) was supposed to be included in those deprecations, however dues to its implementation being different it was missed. This omission can be understood as a bug.This patch deprecates
String.prototype.htmlSafetargeting Ember 4.0. This will allow the removal of all string prototype extensions in 4.0 as intended by the original deprecation.See also: #19654 (comment)