Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing util types #850

Closed
simonihmig opened this issue Jun 15, 2021 · 1 comment · Fixed by #863
Closed

Missing util types #850

simonihmig opened this issue Jun 15, 2021 · 1 comment · Fixed by #863

Comments

@simonihmig
Copy link
Collaborator

#633 added typings for @embroider/util, but this was later removed by #732.
I wonder why? By accident maybe?

This now breaks upgrades for TS projects: Cannot find module '@embroider/util' or its corresponding type declarations.
@ef4
Copy link
Contributor

ef4 commented Jun 15, 2021

Yeah, this was accidental as code moved around.

simonihmig added a commit to simonihmig/embroider that referenced this issue Jun 18, 2021
@simonihmig
Add back util types
2877434 
Fixes embroider-build#850
@simonihmig simonihmig mentioned this issue Jun 18, 2021
Merged
@ef4 ef4 closed this as completed in #863 Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Restore typings for @embroider/util simonihmig/embroider
2 participants
@ef4 @simonihmig