v2 addon shim #732
Merged
v2 addon shim #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Because it is for use in node, and the rest is for use in the browser.
for use in ember-auto-import
we had to move shim up to the top level because that's the path we want people to import
(from ember-auto-import)
To get a newer walkSync, to make it not crash on symlink cycles. Also, I had to fix a bug in broccoli-funnel so this is a fork for now.
This reverts commit dad9d18. This newer broccoli-funnel has too many bugs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will depend on a concurrent release of ember-auto-import, because that is where we polyfill most of the behavior for classic builds. The tl;dr is: v2 addons will just be auto-importable NPM packages that get handled by ember-auto-import in classic builds. This involves extending ember-auto-import so it supports all the v2 features (@embroider/hbs-loader, @embroider/macros) in those packages.