-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert @embroider/addon-dev to ESM #1766
base: stable
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this is blocked on @embroider/addon-dev needing to be ESM.
I think you could use dynamic import inside closeBundle
to not be blocked on esm conversion:
const { execaCommand } = await import('execa');
oh! that's a good idea! I always forget that's a thing. been so long since I've actually had to worry about cjs 😅 |
8484ff9
to
3d8be4c
Compare
Been trying a few different compilation techniques, and it seems that there is a lot of:
style of errors, including from |
@embroider/addon-dev
woah, it's green |
tsc
forbids ESM (even await import) in CJS-output (and we compile withtsc
)fix-bad-declaration-output
is ESM only@embroider/core
requres types forNestedHooks
,beforeAll
, etc, and those types don't exist in addon-dev -- nor do they make sense to exist. Maybe it makes more sense to get rid of those globals and define the types we need to use for those functions.addon.glint()
utility to help out in the v2 addon blueprint