addon-dev: Inline sample files as docs in the README and Porting Addons to V2 Docs. #1797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey keep confusing me.
Co-authored-by: Marine Dunstetter <[email protected]>
Co-authored-by: Marine Dunstetter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extraction from: #1766
In #1766, with the package becoming type=module, the extensions needed to change / be consistent with type=module scheming (use cjs when you mean cjs, mjs when you mean mjs, etc (because v2 addons are actually kind of neither right now)).
Instead of updating the extensions based on the constraints of
@embroider/addon-dev, I inlined the docs, so that the user-land configuration format could be independent from the in-package environment of addon-dev.