Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close proxy dispatch classes on Client.close() #826

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Conversation

tomchristie
Copy link
Member

Closes #824

Actually it would be better for us to gracefully handle the case where one or more close() calls error, and still end up calling all of them, only raising an exception at the end, however there's no reason that we can treat that as an incremental improvement on top of this.

@tomchristie tomchristie added the bug Something isn't working label Feb 26, 2020
@tomchristie tomchristie mentioned this pull request Feb 27, 2020
3 tasks
Copy link
Member

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@tomchristie tomchristie merged commit 2714f32 into master Feb 27, 2020
@tomchristie tomchristie deleted the close-proxies branch February 27, 2020 20:41
@tomchristie tomchristie mentioned this pull request Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many open files if keep changing proxy
2 participants