Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close proxy dispatch classes on Client.close() #826

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Close proxy dispatch classes on Client.close() #826

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions httpx/_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -862,6 +862,8 @@ def delete(

def close(self) -> None:
self.dispatch.close()
for proxy in self.proxies.values():
proxy.close()

def __enter__(self) -> "Client":
return self
Expand Down Expand Up @@ -1388,6 +1390,8 @@ async def delete(

async def aclose(self) -> None:
await self.dispatch.close()
for proxy in self.proxies.values():
await proxy.close()

async def __aenter__(self) -> "AsyncClient":
return self
Expand Down