JSONResponse headers type

[connesy]

The JSONResponse class parameter headers is annotated as typing.Optional[typing.Dict[str, str]], whereas both the base Response class and the other sister-classes (RedirectResponse, StreamingResponse etc) all have headers annotated as typing.Optional[typing.Mapping[str, str]].
Is there any reason for JSONResponse being the odd one out here?

[Kludex]

Probably worth checking when the Mapping were introduced, and see if JSONResponse was forgotten. 🤔

[euri10]

5b56e7d was latest change, and at the time the JSONResponse headers was already different

[Kludex]

I mean the one that introduced Mapping

[euri10]

2b54f42 introduced mapping

[connesy]

It seems like the Mapping was just forgotten in 2b54f42, and then the dict annotation was simply updated alongside the others?

[euri10]

It seems like the Mapping was just forgotten in 2b54f42, and then the dict annotation was simply updated alongside the others?

👍

[connesy]

Should I make an issue and PR?

[Kludex]

You can create a PR, no need for issue. Just link this discussion.

[connesy]

PR: #2187