Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change JSONResponse headers type annotation #2187

Merged
merged 1 commit into from
Jun 16, 2023
Merged

Change JSONResponse headers type annotation #2187

merged 1 commit into from
Jun 16, 2023

Conversation

connesy
Copy link
Contributor

@connesy connesy commented Jun 16, 2023

Summary

As agreed in this discussion (#2186), the type annotation for the headers parameter of JSONResponse is changed from typing.Optional[typing.Dict[str, str]] to typing.Optional[typing.Mapping[str, str]] to align with the other response classes.

Checklist

  • I understand that this PR may be closed in case there was no previous discussion. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.

@adriangb adriangb merged commit 8d7a1ca into encode:master Jun 16, 2023
@connesy connesy deleted the fix/json-response-header-type branch June 16, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants