-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Self heal #116
Self heal #116
Conversation
Hey, with this patch I have full files however for some reason import doesn't work on the first try only after that (it generates the source successfully into the cache dir but can't import them only after the fist run) (I know this is almost a year old issue and maybe it is not even related to it ...) |
@kviktor, is the issue consistent? Can you please add more details describing the failure seen during the first time import. |
#300 prevents partial files from being generated. Processing order has changed. previously: open file -> write header -> parse type library -> generate code -> write body and footer -> close file The interval between opening a file, writing code, and closing it is much shorter, so "an interruption in between" is much rarer. |
@junkmd -- While the changed order definitely makes the issue very rare but the self heal mechanism can act as 2nd level of protection against the small odds or when the file is corrupted later. |
@vijairaj |
…er_self_heal, rebased enthought#116 from 0158d7f to ae2f519
…s in tools.codegenerator and client._generate. (related to enthought#114 and enthought#116)
While I am waiting for a review of the PR I have currently submitted, I thought about what would happen if I applied your proposed logic to the current This code worked at runtime, but there are still problems.
What is your opinion? |
As mentioned in #114, good suggestion about the ability to restore partial modules. However, it is difficult to implement and also difficult to validate with And the current code and module generation process design has changed significantly since this PR was submitted, causing conflicts with the proposed code. Due to no recent activity, I close this. |
Fixes #114