Refactor comtypes.client._generate.GetModule
#300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasily-v-ryabov
added a commit
to vasily-v-ryabov/pywinauto
that referenced
this pull request
Jun 14, 2022
|
Your AppVeyor tests have been successful (except for |
|
All is fine. I was busy/overloaded last 2 weeks. My students were preparing their master's degree presentations about their work on pywinauto. :) |
|
@vasily-v-ryabov |
This was referenced Jun 19, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
client.GetModuleis one of the most used functions incomtypes, but the implemented code is quite a lot of lines.Therefore, I have refactored it by splitting functions according to their roles.
And from the point of view of #114 by @vijairaj,
so I fixed the timing of when the generated code is written to the file.