Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workbench_window.py missing relative path in import #1033

Closed
SurfCityMojo opened this issue Nov 5, 2021 · 4 comments · Fixed by #1034
Closed

workbench_window.py missing relative path in import #1033

SurfCityMojo opened this issue Nov 5, 2021 · 4 comments · Fixed by #1034

Comments

@SurfCityMojo
Copy link

Simple one... Method _editor_manager_default(), is missing relative path in import statement. Should be:

from .editor_manager import EditorManager

@rahulporuri
Copy link
Contributor

Thanks for the report @SurfCityMojo . Can i ask how you came across this issue in the first place? Do you use workbench, directly or indirectly?

rahulporuri pushed a commit that referenced this issue Nov 8, 2021
@rahulporuri
Copy link
Contributor

#1034 should fix this issue.

@SurfCityMojo
Copy link
Author

SurfCityMojo commented Nov 8, 2021 via email

@rahulporuri
Copy link
Contributor

I'm planning on taking a look at migrating it to the Task framework too

We highly recommend doing this as the workbench framework is deprecated and we might remove it in the future.

I think there's a (known?) problem with restoring workbench-based layouts?

I'm not sure. We don't use workbench actively internally so we're not sure what state the workbench framework is in. If you come across issues, please report them. We might not have the time to fix the issues, especially if they are non-trivial but we always welcome external contributions!

rahulporuri pushed a commit that referenced this issue Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants