Fix a broken local import #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdickinson
approved these changes
Nov 8, 2021
I don't think this is an isolated case. I'm afraid there might be more such broken imports, which we aren't catching because the testsuite isn't that good and because we arent using the workbench code internally. I will try to find more such broken imports and see if any useful tools exist (I'd be surprised if i find none) |
For now, I manually went over the workbench code in pyface and found no other broken imports. I just manually inspected the workbench modules, it didn't take long. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1033
This PR fixes a broken local import in the workbench machinery.