-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The _create method should be public #729
Labels
difficulty: easy
Issues which don't need much/any context about the package.
Feature
type: refactoring
Issues related to refactoring
Milestone
Comments
corranwebster
added
difficulty: easy
Issues which don't need much/any context about the package.
Feature
type: refactoring
Issues related to refactoring
labels
Oct 10, 2020
Strategy for removing
|
I've added this to the 8.0 release - the next few steps in this should be done for that release, if time permits. It will not be completed in the 8.0 release, however. |
This was referenced Mar 11, 2023
corranwebster
added a commit
that referenced
this issue
Mar 14, 2023
This carries out the next two steps of #729 - [x] replaces calls to `_create` with calls to `create` - [x] that classes migrate the implementation of `_create` into `create`, and make `_create` call `create` as well as the next step in removing `create` calls from `__init__` methods: - [x] properly deprecate auto-create, but don't fail yet; push toward removing `create` keyword argument.
Incremental progress in the 8.0 release, the rest pushed to 9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
difficulty: easy
Issues which don't need much/any context about the package.
Feature
type: refactoring
Issues related to refactoring
The base
Widget._create
method is nominally private, but in practice tends to get used as:although a few widgets perform the
_create()
call as part of their__init__
.Two-phase creation has an advantage in that it permits programmatic configuration of the widget beyond what is passed in at class creation time before the underlying toolkit control is created.
This issue proposes that:
create
method, which initially can be implemented to simple call_create
(Add a create method for IWidget #735)_create
are changed to calls tocreate
_create
intocreate
, and make_create
callcreate
_create
is removedAdditionally:
_create
or (worse)_create_control
in their__init__
be modified to not do thatIWidget
interface (such asITaskPane
) should be modified to inherit fromIWidget
and their implementations to inherit fromWidget
.The text was updated successfully, but these errors were encountered: