HeadingText fixes #976
Merged
HeadingText fixes #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- aligns Qt _create_control with standard API - route creation throught create() call - make widget creation in init() optional - deprecate automatic widget creation - various other small fixes
- appearance of Qt and Wx are similar - changes to text are dispatched on the ui thread - general clean-up and standardization
rahulporuri
requested review from
rahulporuri and
aaronayres35
and removed request for
aaronayres35
rahulporuri
approved these changes
Jul 13, 2021
Comment on lines
+47
to
+51
| warnings.warn( | ||
| "background images are no-longer supported for Wx and the " | ||
| "'image' trait will be removed in a future Pyface update", | ||
| PendingDeprecationWarning, | ||
| ) |
There was a problem hiding this comment.
can you create an issue for this deprecation - and put it in the 8.0.0 milestone?
Comment on lines
+61
to
+66
| warnings.warn( | ||
| "automatic widget creation is deprecated and will be removed " | ||
| "in a future Pyface version, use create=False and explicitly " | ||
| "call create() for future behaviour", | ||
| PendingDeprecationWarning, | ||
| ) |
There was a problem hiding this comment.
same comment here regd an issue - and we can put this in the 8.0.0 milestone too if that makes sense.
There was a problem hiding this comment.
This is part of #729 (particularly the comment at the bottom about automatic creation in __init__).
But I don't want to add it to a milestone until all of them are dealt with (ie. if I don't get it done this week it might bet Pyface 9 where we finally get rid of them).
There was a problem hiding this comment.
I've added a comment to #729 which goes over the idea for the sequence of events needed to change the API safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements and fixes for HeadingText: