Fix test hangs with PySide2 / Big Sur #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have - I've been seeing it on #1055 but had assumed it was because of changes made for Qt6 compatibility. |
Ah, excellent. I was a bit worried that there was something more subtle going on. I've pushed the other half of the fix. |
corranwebster
approved these changes
Dec 17, 2021
rahulporuri
pushed a commit
to enthought/traitsui
that referenced
this pull request
Dec 17, 2021
See enthought/pyface#1056 modified: .github/workflows/bleeding-edge.yml modified: .github/workflows/test-with-edm.yml modified: .github/workflows/test-with-pip.yml
rahulporuri
pushed a commit
to enthought/traitsui
that referenced
this pull request
Dec 17, 2021
* MAINT: Upgrade edm to use the latest version on CI - 3.3.0 modified: .github/workflows/test-etsdemo.yml modified: .github/workflows/test-with-edm.yml * DEV: Use EDM 3.3.1 modified: .github/workflows/test-etsdemo.yml modified: .github/workflows/test-with-edm.yml * FIX: Fix test hangs with PySide2/Big Sur See enthought/pyface#1056 modified: .github/workflows/bleeding-edge.yml modified: .github/workflows/test-with-edm.yml modified: .github/workflows/test-with-pip.yml
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cron job recently started hanging for builds on PySide2 / macOS; this seems likely to be related to the GitHub Actions move to macOS 11 for its workers.
This (draft) PR gives half of a fix: it fixes the cron job, but not the PR build. I'll add the other half once I've confirmed that the same problem occurs for the PR build (right now we haven't see the issue on PRs).
xref: https://github.com/enthought/pyface/runs/4558033525?check_suite_focus=true