Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade edm to use the latest version on CI - 3.3.0 #1785

Merged
merged 3 commits into from
Dec 17, 2021

Conversation

rahulporuri
Copy link
Contributor

This PR upgrades EDM to the latest available version - 3.3.0 - on the CI.

Checklist

  • Add a news fragment if this PR is news-worthy for end users. (see docs/releases/README.rst) Not news-worthy.

	modified:   .github/workflows/test-etsdemo.yml
	modified:   .github/workflows/test-with-edm.yml
@rahulporuri
Copy link
Contributor Author

well that's disappointing. the setup edm action failed -

Run enthought/setup-edm-action@v1
  with:
    edm-version: 3.3.0
    download-directory: ~/.cache/download
  env:
    INSTALL_EDM_VERSION: 3.3.0
    EDM_ROOT_DIRECTORY: /home/runner/work/traitsui/traitsui/.edm
Using directory for storing downloaded installer: /home/runner/.cache/download
/usr/bin/bash /home/runner/work/_actions/enthought/setup-edm-action/v1/dist/install-edm-linux.sh 3.3.0 /home/runner/.cache/download
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100   243    0   243    0     0   1327      0 --:--:-- --:--:-- --:--:--  1327
/home/runner/.cache/download/edm_cli_3.3.0_linux_x86_64.sh: line 1: syntax error near unexpected token `newline'
/home/runner/.cache/download/edm_cli_3.3.0_linux_x86_64.sh: line 1: `<?xml version="1.0" encoding="UTF-8"?>'
(node:1570) UnhandledPromiseRejectionWarning: Error: The process '/usr/bin/bash' failed with exit code 2
    at ExecState._setResult (/home/runner/work/_actions/enthought/setup-edm-action/v1/dist/index.js:1026:25)
    at ExecState.CheckComplete (/home/runner/work/_actions/enthought/setup-edm-action/v1/dist/index.js:1009:18)
    at ChildProcess.<anonymous> (/home/runner/work/_actions/enthought/setup-edm-action/v1/dist/index.js:903:27)
    at ChildProcess.emit (events.js:314:20)
    at maybeClose (internal/child_process.js:1022:16)
    at Socket.<anonymous> (internal/child_process.js:444:11)
    at Socket.emit (events.js:314:20)
    at Pipe.<anonymous> (net.js:675:12)
(node:1570) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
(node:1570) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

ref https://github.com/enthought/traitsui/runs/4403939868?check_suite_focus=true.

@mdickinson
Copy link
Member

EDM 3.3.0 should be uploaded; closing and re-opening to test.

@mdickinson mdickinson closed this Dec 3, 2021
@mdickinson mdickinson reopened this Dec 3, 2021
	modified:   .github/workflows/test-etsdemo.yml
	modified:   .github/workflows/test-with-edm.yml
Copy link
Member

@mdickinson mdickinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdickinson
Copy link
Member

Looks like we have the same Big Sur / EDM PySide2 issue as on Envisage and Pyface.

See enthought/pyface#1056

	modified:   .github/workflows/bleeding-edge.yml
	modified:   .github/workflows/test-with-edm.yml
	modified:   .github/workflows/test-with-pip.yml
@rahulporuri rahulporuri merged commit ca1e1bd into main Dec 17, 2021
@rahulporuri rahulporuri deleted the maint/upgrade-edm-to-3.3.0 branch December 17, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants