Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dont install traitsui from git source #787

Merged
merged 2 commits into from
Nov 2, 2020

Conversation

rahulporuri
Copy link
Contributor

fixes #775

This PR updates CI/etstool module to install traitsui using edm instead of installing it from git source.

	modified:   ci-src-requirements.txt
	modified:   etstool.py
@kitchoi
Copy link
Contributor

kitchoi commented Oct 26, 2020

I think this should get reviewed by @corranwebster.
Historically Pyface and TraitsUI have been installing each other's master on their CIs, which to me, effectively means they are developed as if they were one distribution. One of the main purposes of separating code into two distributions would be such that the two can be released at different time, and such that the dependent distribution can opt to depend on an older version of another. To achieve that CI should not install each other masters, so I agree the change in principle simply based on the fact that Pyface and TraitsUI are separate distributions. However I am not sure in practice they were actually separate distributions, I am afraid the severed link will bring in even more unnecessary costs.

@rahulporuri
Copy link
Contributor Author

@kitchoi based on offline discussion, it looks like we should be able to merge these PRs now. right?

@rahulporuri rahulporuri merged commit 65e526b into master Nov 2, 2020
@rahulporuri rahulporuri deleted the dev/dont-use-traitsui-from-source branch November 2, 2020 19:48
@rahulporuri rahulporuri removed the request for review from corranwebster November 3, 2020 08:29
@kitchoi
Copy link
Contributor

kitchoi commented Nov 3, 2020

based on offline discussion, it looks like we should be able to merge these PRs now. right?

For future reference, the offline discussion referred to here is that @corranwebster confirmed to go ahead with installing released TraitsUI in Pyface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't install traitsui from source after 7.1.0 release
2 participants